lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 5 Mar 2019 17:59:57 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
CC:     Support Opensource <support.opensource@...semi.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Cirrus Patches <patches@...nsource.cirrus.com>
Subject: [PATCH 00/13] Fix backtrace warnings from bad notifier chain calls


Hi Mark,

This patch-set fixes a WARN_ON_ONCE() backtrace call caused by not
locking the mutex from the function call regulator_notifier_call_chain().
It does this for thirteen regulator drivers by adding a mutex lock
surrounding the notifier calls.

This missing mutex lock has been around for a while, but the API I have
used used here to fix it (i.e. regulator_lock()/regulator_unlock()) has
only been in the kernel since v4.18. Therefore as this fix stands, the
patches do not port back very far in kernel history.

Regards,
Steve


Steve Twiss (13):
  regulator: da9055: Fix notifier mutex lock warning
  regulator: da9062: Fix notifier mutex lock warning
  regulator: da9063: Fix notifier mutex lock warning
  regulator: da9211: Fix notifier mutex lock warning
  regulator: lp8755: Fix notifier mutex lock warning
  regulator: ltc3589: Fix notifier mutex lock warning
  regulator: ltc3676: Fix notifier mutex lock warning
  regulator: pv88060: Fix notifier mutex lock warning
  regulator: pv88080: Fix notifier mutex lock warning
  regulator: pv88090: Fix notifier mutex lock warning
  regulator: wm831x: Fix notifier mutex lock warning
  regulator: wm831x isink: Fix notifier mutex lock warning
  regulator: wm831x ldo: Fix notifier mutex lock warning

 drivers/regulator/da9055-regulator.c  |  2 ++
 drivers/regulator/da9062-regulator.c  |  2 ++
 drivers/regulator/da9063-regulator.c  |  5 ++++-
 drivers/regulator/da9211-regulator.c  |  4 ++++
 drivers/regulator/lp8755.c            | 15 ++++++++++++---
 drivers/regulator/ltc3589.c           | 10 ++++++++--
 drivers/regulator/ltc3676.c           | 10 ++++++++--
 drivers/regulator/pv88060-regulator.c |  4 ++++
 drivers/regulator/pv88080-regulator.c |  4 ++++
 drivers/regulator/pv88090-regulator.c |  4 ++++
 drivers/regulator/wm831x-dcdc.c       |  4 ++++
 drivers/regulator/wm831x-isink.c      |  2 ++
 drivers/regulator/wm831x-ldo.c        |  2 ++
 13 files changed, 60 insertions(+), 8 deletions(-)

-- 
1.9.3

Powered by blists - more mailing lists