linux-kernel - Re: [GIT PULL 4/6] ARM: SoC defconfig updates for 5.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Mar 2019 10:15:17 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     soc@...nel.org, Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        arm-soc <arm@...nel.org>
Subject: Re: [GIT PULL 4/6] ARM: SoC defconfig updates for 5.1

Another small side note on these pull requests:

On Wed, Mar 6, 2019 at 7:35 AM Arnd Bergmann <arnd@...db.de> wrote:
>
>  arch/arm/configs/lpc32xx_defconfig    | 65
> +++++++++++++++++++++++++++++++----------------------------------

You have a lot of these kinds of line-wrapped diffstat lines.

The reason is *probably* that you've just cut-and-pasted from your
(very wide) terminal where you ran your scripts into the email.

Becaue if you run "git diff --stat" normally in a germinal, it will
take the terminal width into account.

If you run it in a script to a file or pipe, it will default width of
80 columns.

You could make your scripts just do "--stat=80" to do that, but you
might also consider using "xsel" to avoid the cutting-and-selecting
part, and just do

    my-release-script | xsel

to select the output of the script, and then paste it with your mouse...

This is not a big deal, but it does make those diffstats ugly, and I
_suspect_ it's because you didn't realize what is going on.

             Linus