linux-kernel - Re: [GIT PULL 3/6] ARM: SoC driver updates for 5.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190306181557.fndmy5oks3sximeo@shell.armlinux.org.uk>
Date:   Wed, 6 Mar 2019 18:15:57 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>, soc@...nel.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        arm-soc <arm@...nel.org>
Subject: Re: [GIT PULL 3/6] ARM: SoC driver updates for 5.1

On Wed, Mar 06, 2019 at 10:09:28AM -0800, Linus Torvalds wrote:
> On Wed, Mar 6, 2019 at 7:34 AM Arnd Bergmann <arnd@...db.de> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/armsoc-drivers
> 
> This caused a surprising number of kernel file rebuilds for me, and
> the reason was
> 
> >  include/linux/mod_devicetable.h                                     |   9 +
> 
> It turns out that the above is indirectly included from a _lot_ of
> code device header files.
> 
> The reason seems to be the various 'struct *_device_id' declarations,
> that then all the different header files want.
> 
> So a tiny change in an oddball header file causes a lot of recompiles.
> 
> Oh well. I don't know if there is anything to be done, but I did react
> to how some surprising changes cause a lot of build activity, and it's
> not always obvious.

Would it be worth splitting up mod_devicetable.h and having drivers
include just the bus-specific device table header(s) that the driver
requires?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up