linux-kernel - Re: [PATCH] RDMA/umem: updated bug fix in error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190306184554.GG1662@ziepe.ca>
Date:   Wed, 6 Mar 2019 14:45:54 -0400
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     john.hubbard@...il.com
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        John Hubbard <jhubbard@...dia.com>,
        Artemy Kovalyov <artemyko@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>,
        Ira Weiny <ira.weiny@...el.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org
Subject: Re: [PATCH] RDMA/umem: updated bug fix in error handling path

On Tue, Mar 05, 2019 at 06:00:22PM -0800, john.hubbard@...il.com wrote:
> From: John Hubbard <jhubbard@...dia.com>
> 
> The previous attempted bug fix overlooked the fact that
> ib_umem_odp_map_dma_single_page() was doing a put_page()
> upon hitting an error. So there was not really a bug there.
> 
> Therefore, this reverts the off-by-one change, but
> keeps the change to use release_pages() in the error path.
> 
> Fixes: commit xxxxxxxxxxxx ("RDMA/umem: minor bug fix in error handling path")
> Suggested-by: Artemy Kovalyov <artemyko@...lanox.com>
> 
> Cc: Leon Romanovsky <leon@...nel.org>
> Cc: Ira Weiny <ira.weiny@...el.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Doug Ledford <dledford@...hat.com>
> Cc: linux-rdma@...r.kernel.org
> Cc: linux-mm@...ck.org
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
>  drivers/infiniband/core/umem_odp.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Applied to for-next, thanks

Jason