linux-kernel - Re: [PATCH 1/2] appletalk: Fix compile regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190306.104715.777357136943937872.davem@davemloft.net>
Date:   Wed, 06 Mar 2019 10:47:15 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     netdev@...r.kernel.org, yuehaibing@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] appletalk: Fix compile regression

From: Arnd Bergmann <arnd@...db.de>
Date: Wed,  6 Mar 2019 11:52:36 +0100

> A bugfix just broke compilation of appletalk when CONFIG_SYSCTL
> is disabled:
> 
> In file included from net/appletalk/ddp.c:65:
> net/appletalk/ddp.c: In function 'atalk_init':
> include/linux/atalk.h:164:34: error: expected expression before 'do'
>  #define atalk_register_sysctl()  do { } while(0)
>                                   ^~
> net/appletalk/ddp.c:1934:7: note: in expansion of macro 'atalk_register_sysctl'
>   rc = atalk_register_sysctl();
> 
> This is easier to avoid by using conventional inline functions
> as stubs rather than macros. The header already has inline
> functions for other purposes, so I'm changing over all the
> macros for consistency.
> 
> Fixes: 6377f787aeb9 ("appletalk: Fix use-after-free in atalk_proc_exit")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.