linux-kernel - Re: [PATCH v5 07/10] perf record: implement -z,--compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 11:26:31 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 07/10] perf record: implement -z,--compression_level=n
 option and compression


On 05.03.2019 15:26, Jiri Olsa wrote:
> On Fri, Mar 01, 2019 at 06:58:32PM +0300, Alexey Budankov wrote:
> 
> SNIP
> 
>> +static int record__aio_enabled(struct record *rec);
>> +
>>  static void record__aio_mmap_read_sync(struct record *rec)
>>  {
>>  	int i;
>>  	struct perf_evlist *evlist = rec->evlist;
>>  	struct perf_mmap *maps = evlist->mmap;
>>  
>> -	if (!rec->opts.nr_cblocks)
>> +	if (!record__aio_enabled(rec))
>>  		return;
>>  
>>  	for (i = 0; i < evlist->nr_mmaps; i++) {
>> @@ -292,13 +294,17 @@ static int record__aio_parse(const struct option *opt,
>>  
>>  	if (unset) {
>>  		opts->nr_cblocks = 0;
>> -	} else {
>> -		if (str)
>> -			opts->nr_cblocks = strtol(str, NULL, 0);
>> -		if (!opts->nr_cblocks)
>> -			opts->nr_cblocks = nr_cblocks_default;
>> +		return 0;
>>  	}
>>  
>> +	if (str)
>> +		opts->nr_cblocks = strtol(str, NULL, 0);
>> +	if (!opts->nr_cblocks)
>> +		opts->nr_cblocks = nr_cblocks_default;
>> +
>> +	if (opts->nr_cblocks > nr_cblocks_max)
>> +		opts->nr_cblocks = nr_cblocks_max;
>> +
>>  	return 0;
> 
> does not seem to be related to the patch, if that's the case please separate

in v7.

~Alexey

> 
> jirka
>