linux-kernel - Re: [PATCH] ASoC: ams-delta: remove duplicate 'const'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190307152206.GF20201@archlinux-ryzen>
Date:   Thu, 7 Mar 2019 08:22:06 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Peter Ujfalusi <peter.ujfalusi@...com>,
        Mark Brown <broonie@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Tony Lindgren <tony@...mide.com>,
        Jarkko Nikula <jarkko.nikula@...mer.com>,
        Janusz Krzysztofik <jmkrzyszt@...il.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: ams-delta: remove duplicate 'const'

On Thu, Mar 07, 2019 at 11:10:49AM +0100, Arnd Bergmann wrote:
> clang points out that SOC_ENUM_SINGLE_EXT_DECL() contains a 'const'
> modifier already, so adding another one does not make it more const:
> 
> sound/soc/ti/ams-delta.c:203:14: error: duplicate 'const' declaration specifier [-Werror,-Wduplicate-decl-specifier]
> static const SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
>              ^
> include/sound/soc.h:351:2: note: expanded from macro 'SOC_ENUM_SINGLE_EXT_DECL'
>         const struct soc_enum name = SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(xtexts), xtexts)
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Nathan Chancellor <natechancellor@...il.com>

> ---
>  sound/soc/ti/ams-delta.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/ti/ams-delta.c b/sound/soc/ti/ams-delta.c
> index 4dce494dfbd3..b9611db14c86 100644
> --- a/sound/soc/ti/ams-delta.c
> +++ b/sound/soc/ti/ams-delta.c
> @@ -200,7 +200,7 @@ static int ams_delta_get_audio_mode(struct snd_kcontrol *kcontrol,
>  	return 0;
>  }
>  
> -static const SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
> +static SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
>  				      ams_delta_audio_mode);
>  
>  static const struct snd_kcontrol_new ams_delta_audio_controls[] = {
> -- 
> 2.20.0
>