linux-kernel - Re: [PATCH] coresight: catu: fix clang build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 10:24:29 -0700
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        ndesaulniers@...gle.com, Greg KH <gregkh@...uxfoundation.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] coresight: catu: fix clang build warning

On Thu, 7 Mar 2019 at 03:48, Suzuki K Poulose <suzuki.poulose@....com> wrote:
>
> Hi Arnd,
>
> On 07/03/2019 10:32, Arnd Bergmann wrote:
> > Clang points out a syntax error, as the etr_catu_buf_ops structure is
> > declared 'static' before the type is known:
> >
> > In file included from drivers/hwtracing/coresight/coresight-tmc-etr.c:12:
> > drivers/hwtracing/coresight/coresight-catu.h:116:40: warning: tentative definition of variable with internal linkage has incomplete non-array type 'const struct etr_buf_operations' [-Wtentative-definition-incomplete-type]
> > static const struct etr_buf_operations etr_catu_buf_ops;
> >                                         ^
> > drivers/hwtracing/coresight/coresight-catu.h:116:21: note: forward declaration of 'struct etr_buf_operations'
> > static const struct etr_buf_operations etr_catu_buf_ops;
> >
> > This seems worth fixing in the code, so replace pointer to the empty
> > constant structure with a NULL pointer. We need an extra NULL pointer
> > check here, but the result should be better object code otherwise,
> > avoiding the silly empty structure.
> >
> > Fixes: 434d611cddef ("coresight: catu: Plug in CATU as a backend for ETR buffer")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Thanks for the fix.
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>

Applied after fixing line over 80 characters.

Thanks,
Mathieu