linux-kernel - Re: [PATCH v2 08/15] ARM: shmobile: fix a leaked reference by adding missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190308120743.bsqma3pp6h52bd53@verge.net.au>
Date:   Fri, 8 Mar 2019 13:07:43 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Wen Yang <wen.yang99@....com.cn>
Cc:     linux-kernel@...r.kernel.org, wang.yi59@....com.cn,
        Magnus Damm <magnus.damm@...il.com>,
        Russell King <linux@...linux.org.uk>,
        linux-renesas-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 08/15] ARM: shmobile: fix a leaked reference by adding
 missing of_node_put

On Tue, Mar 05, 2019 at 07:33:59PM +0800, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
> 
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
> ./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
> ./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function.
> 
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Simon Horman <horms@...ge.net.au>
> Cc: Magnus Damm <magnus.damm@...il.com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: linux-renesas-soc@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> ---
> v2->v1: add a missing space between "adding" and "missing"

Thanks, I have this applied for inclusion in v5.2.

>  arch/arm/mach-shmobile/pm-rcar-gen2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c b/arch/arm/mach-shmobile/pm-rcar-gen2.c
> index 8c2a205..e84599d 100644
> --- a/arch/arm/mach-shmobile/pm-rcar-gen2.c
> +++ b/arch/arm/mach-shmobile/pm-rcar-gen2.c
> @@ -72,6 +72,7 @@ void __init rcar_gen2_pm_init(void)
>  	}
>  
>  	error = of_address_to_resource(np, 0, &res);
> +	of_node_put(np);
>  	if (error) {
>  		pr_err("Failed to get smp-sram address: %d\n", error);
>  		return;
> -- 
> 2.9.5
>