linux-kernel - Re: [PATCH v2 02/15] ARM: bcm: fix a leaked reference by adding missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <472373f4-fc8e-3c8d-a2a3-e6cba261e2a7@gmail.com>
Date:   Fri, 8 Mar 2019 10:50:07 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Ray Jui <ray.jui@...adcom.com>, Wen Yang <wen.yang99@....com.cn>,
        linux-kernel@...r.kernel.org
Cc:     wang.yi59@....com.cn, Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 02/15] ARM: bcm: fix a leaked reference by adding
 missing of_node_put

On 3/5/19 9:24 AM, Ray Jui wrote:
> 
> 
> On 3/5/2019 3:33 AM, Wen Yang wrote:
>> The call to of_get_next_child returns a node pointer with refcount
>> incremented thus it must be explicitly decremented after the last
>> usage.
>>
>> Detected by coccinelle with the following warnings:
>> ./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function.
>>
>> Signed-off-by: Wen Yang <wen.yang99@....com.cn>
>> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>> Cc: Florian Fainelli <f.fainelli@...il.com>
>> Cc: Ray Jui <rjui@...adcom.com>
>> Cc: Scott Branden <sbranden@...adcom.com>
>> Cc: bcm-kernel-feedback-list@...adcom.com
>> Cc: Russell King <linux@...linux.org.uk>
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-kernel@...r.kernel.org
>> ---
>> v2->v1: add a missing space between "adding" and "missing"
>>
>>  arch/arm/mach-bcm/board_bcm281xx.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-bcm/board_bcm281xx.c b/arch/arm/mach-bcm/board_bcm281xx.c
>> index b81bb38..1238ac8 100644
>> --- a/arch/arm/mach-bcm/board_bcm281xx.c
>> +++ b/arch/arm/mach-bcm/board_bcm281xx.c
>> @@ -38,6 +38,7 @@ static void bcm281xx_restart(enum reboot_mode mode, const char *cmd)
>>  		return;
>>  	}
>>  	base = of_iomap(np_wdog, 0);
>> +	of_node_put(np_wdog);
>>  	if (!base) {
>>  		pr_emerg("Couldn't map brcm,kona-wdt\n");
>>  		return;
>>
> 
> Change looks good to me. Thanks!
> 
> Acked-by: Ray Jui <ray.jui@...adcom.com>
> 

Squashed this patch and "[PATCH 1/4] ARM: brcmstb: fix a leaked
reference by adding missing of_node_put" into the same commit:

https://github.com/Broadcom/stblinux/commit/ff98f8f6083a7f317463f538e9a21822e1128657

thanks Wen!

-- 
Florian