linux-kernel - Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e0a5485-d338-e4e8-5333-cac873158a93@ti.com>
Date:   Fri, 8 Mar 2019 15:08:16 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <robh+dt@...nel.org>, <jacek.anaszewski@...il.com>,
        <tony@...mide.com>, <lee.jones@...aro.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-leds@...r.kernel.org>
Subject: Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt
 properties

Pavel

On 3/8/19 3:06 PM, Pavel Machek wrote:
> 
>>>> +		led@1 {
>>>> +			reg = <1>;
>>>> +			led-sources = <1>;
>>>> +			ti,led-mode = <LM3532_BL_MODE_MANUAL>;
>>>> +			label = "keypad";
>>>
>>> I guess best variant would be inputX::backlight here, but that might
>>> be tricky to implement.
>>>
>>
>> Yeah because we don't know what input the keyboard would be on.
>> Unless there are APIs to retrieve that info.  I have not looked at the input
>> framework in a while.
> 
> Lets just make it "platform::kbd_backlight". *:kbd_backlight is
> already used by quite a few drivers.
> 

Sounds fine to me.  I will update in v3 as I posted v2 with a lot of deltas

Dan

> 									Pavel
> 


-- 
------------------
Dan Murphy