lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 9 Mar 2019 11:50:57 +0100
From:   Linus Walleij <>
To:     Manivannan Sadhasivam <>
Cc:     Russell King <>,
        Xu Wei <>,
        Linux ARM <>,
        "" <>,
        Daniel Thompson <>,
        Peter Griffin <>,
        Guodong Xu <>,
        Haojian Zhuang <>
Subject: Re: [PATCH 1/2] amba: Take device out of reset before reading pid and
 cid values

On Sat, Mar 9, 2019 at 2:59 AM Manivannan Sadhasivam
<> wrote:

> For the AMBA Primecell devices having the reset lines wired, it is
> necessary to take them out of reset before reading the pid and cid values.
> Earlier we were dependent on the bootloader to do this but a more cleaner
> approach would be to do it in the kernel itself. Hence, this commit
> deasserts the reset line just before reading the pid and cid values.
> Suggested-by: Daniel Thompson <>
> Signed-off-by: Manivannan Sadhasivam <>

This looks correct to me.
Reviewed-by: Linus Walleij <>

I think you can put it in Russell's patch tracker in some week.

Linus Walleij

Powered by blists - more mailing lists