linux-kernel - Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdboriy8xym-Czj5g6=3MpiZB8-W45Z62nNQER9S9XsrZQ@mail.gmail.com>
Date:   Sat, 9 Mar 2019 11:50:57 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Russell King <linux@...linux.org.uk>,
        Xu Wei <xuwei5@...ilicon.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Peter Griffin <peter.griffin@...aro.org>,
        Guodong Xu <guodong.xu@...aro.org>,
        Haojian Zhuang <haojian.zhuang@...aro.org>
Subject: Re: [PATCH 1/2] amba: Take device out of reset before reading pid and
 cid values

On Sat, Mar 9, 2019 at 2:59 AM Manivannan Sadhasivam
<manivannan.sadhasivam@...aro.org> wrote:

> For the AMBA Primecell devices having the reset lines wired, it is
> necessary to take them out of reset before reading the pid and cid values.
> Earlier we were dependent on the bootloader to do this but a more cleaner
> approach would be to do it in the kernel itself. Hence, this commit
> deasserts the reset line just before reading the pid and cid values.
>
> Suggested-by: Daniel Thompson <daniel.thompson@...aro.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

This looks correct to me.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I think you can put it in Russell's patch tracker in some week.

Yours,
Linus Walleij