linux-kernel - Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Mar 2019 10:12:48 +0200
From:   Alexandru Ardelean <ardeleanalex@...il.com>
To:     Karen Palacio <karen.palacio.1994@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, devel@...verdev.osuosl.org,
        linux-iio@...r.kernel.org, gregkh@...uxfoundation.org,
        Peter Meerwald-Stadler <pmeerw@...erw.net>, knaack.h@....de,
        Jonathan Cameron <jic23@...nel.org>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        lars@...afoo.de, Mircea Caprioru <mircea.caprioru@...log.com>
Subject: Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio
<karen.palacio.1994@...il.com> wrote:
>
> Add spaces around minus operator to fix readibility.
>
> Signed-off-by: Karen Palacio <karen.palacio.1994@...il.com>
> ---
>  drivers/staging/iio/adc/ad7192.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index acdbc07..7c632cf 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev,
>  }
>
>  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> -                            in_voltage-voltage_scale_available,
> +                            in_voltage - voltage_scale_available,

This isn't broken, but I do agree it should be addressed.
I think it's the second time I see a similar patch trying to fix this.
So, obviously the code is a bit misleading.

>                              0444, ad7192_show_scale_available, NULL, 0);
>
>  static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> --
> 2.7.4
>