linux-kernel - Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190311083159.GE2434@kadam>
Date:   Mon, 11 Mar 2019 11:31:59 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Alexandru Ardelean <ardeleanalex@...il.com>
Cc:     Karen Palacio <karen.palacio.1994@...il.com>,
        devel@...verdev.osuosl.org, lars@...afoo.de,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        linux-iio@...r.kernel.org, gregkh@...uxfoundation.org,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>, knaack.h@....de,
        Mircea Caprioru <mircea.caprioru@...log.com>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus
 operator

On Mon, Mar 11, 2019 at 10:12:48AM +0200, Alexandru Ardelean wrote:
> On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio
> <karen.palacio.1994@...il.com> wrote:
> >
> > Add spaces around minus operator to fix readibility.
> >
> > Signed-off-by: Karen Palacio <karen.palacio.1994@...il.com>
> > ---
> >  drivers/staging/iio/adc/ad7192.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index acdbc07..7c632cf 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -355,7 +355,7 @@ ad7192_show_scale_available(struct device *dev,
> >  }
> >
> >  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> > -                            in_voltage-voltage_scale_available,
> > +                            in_voltage - voltage_scale_available,
> 
> This isn't broken, but I do agree it should be addressed.
> I think it's the second time I see a similar patch trying to fix this.
> So, obviously the code is a bit misleading.
> 

It's got to be more than that.  I did a simple grep of my inbox and it
says that this is the 13th time someone has tried to do this.  It's
possible that my grep is wrong, 13 seems high but not totaly impossible.

regards,
dan carpenter