linux-kernel - Re: [PATCH 2/2] ARM: futex: make futex_detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu__jgnm00ou+3FsqRBZWeDFy5Qi+1eiXeMKqc+hVSXomg@mail.gmail.com>
Date:   Mon, 11 Mar 2019 17:36:14 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Mikael Pettersson <mikpelinux@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Darren Hart <dvhart@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Martin <Dave.Martin@....com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/2] ARM: futex: make futex_detect_cmpxchg more reliable

On Mon, 11 Mar 2019 at 17:30, Arnd Bergmann <arnd@...db.de> wrote:
>
> On Mon, Mar 11, 2019 at 3:36 PM Ard Biesheuvel
> <ard.biesheuvel@...aro.org> wrote:
> > On Mon, 11 Mar 2019 at 15:34, Arnd Bergmann <arnd@...db.de> wrote:
> > > On Fri, Mar 8, 2019 at 12:56 PM Ard Biesheuvel
> > > <ard.biesheuvel@...aro.org> wrote:
> > > > On Fri, 8 Mar 2019 at 11:58, Russell King - ARM Linux admin <linux@...linux.org.uk> wrote:
> > > > > On Fri, Mar 08, 2019 at 11:45:21AM +0100, Ard Biesheuvel wrote:
> > >
> > > My first attempt (before finding the original patch from Mikael Pettersson)
> > > was to change the probe to pass '1' as the value instead of '0', that
> > > worked fine.
> > >
> >
> > Which probe is that?
>
> diff --git a/kernel/futex.c b/kernel/futex.c
> index c3b73b0311bc..19615ad3c4f7 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -3864,7 +3864,7 @@ static void __init futex_detect_cmpxchg(void)
>          * implementation, the non-functional ones will return
>          * -ENOSYS.
>          */
> -       if (cmpxchg_futex_value_locked(&curval, NULL, 0, 0) == -EFAULT)
> +       if (cmpxchg_futex_value_locked(&curval, NULL, 1, 1) == -EFAULT)
>                 futex_cmpxchg_enabled = 1;
>  #endif
>  }
>

Ah ok.

That explains a lot.

Can't we just return -EFAULT if uaddr is NULL? Or does that defeat this check?

Note that PA-RISC has

        /* futex.c wants to do a cmpxchg_inatomic on kernel NULL, which is
         * our gateway page, and causes no end of trouble...
         */
        if (uaccess_kernel() && !uaddr)
                return -EFAULT;