linux-kernel - Re: BUG: MAX_STACK_TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wh_H+Wce_n8vW68ZzoSs3m=exP+kKZZZRCxAfi6dG2_Mg@mail.gmail.com>
Date:   Mon, 11 Mar 2019 10:48:07 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     syzbot <syzbot+78923eea7cf44364f4fb@...kaller.appspotmail.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Darrick J. Wong" <darrick.wong@...cle.com>, dledford@...hat.com,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Christoph Hellwig <hch@...radead.org>,
        Jann Horn <jannh@...gle.com>, Jason Gunthorpe <jgg@...pe.ca>,
        johannes.berg@...el.com, leon@...nel.org,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        linux-rdma@...r.kernel.org, linux-xfs@...r.kernel.org,
        Waiman Long <longman@...hat.com>,
        Ingo Molnar <mingo@...nel.org>, Ingo Molnar <mingo@...hat.com>,
        Paul McKenney <paulmck@...ux.vnet.ibm.com>,
        Peter Zijlstra <peterz@...radead.org>, roland@...estorage.com,
        sean.hefty@...el.com, shamir.rabinovitch@...cle.com,
        swise@...ngridcomputing.com, syzkaller-bugs@...glegroups.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Tejun Heo <tj@...nel.org>, Will Deacon <will.deacon@....com>,
        Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: BUG: MAX_STACK_TRACE_ENTRIES too low!

On Mon, Mar 11, 2019 at 8:19 AM Bart Van Assche <bvanassche@....org> wrote:
>
> I think this issue has been fixed by a commit that went upstream yesterday. Hence:
>
> #syz fix: workqueue, lockdep: Fix an alloc_workqueue() error path

Well, syzbot just reported a problem with that fix itself ("WARNING in
lockdep_unregister_key").

Looks like now the lockdep_unregister_key() cleanup might be called
even when the lockdep map was never initialized at all in that error
case. Hmm?

I _think_ you need to split that "err_free_wq" label into "just free
the wq" and "unregister lockdep and free wq".

But I didn't look any more closely, I might be misreading things.

                Linus