linux-kernel - Re: [PATCH] drm/bochs: Fix NULL dereference on atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190311174958.xdw4lrvf6ydeplvc@smtp.gmail.com>
Date:   Mon, 11 Mar 2019 14:49:58 -0300
From:   Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
To:     Gerd Hoffmann <kraxel@...hat.com>
Cc:     David Airlie <airlied@...ux.ie>,
        virtualization@...ts.linux-foundation.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

On 03/11, Gerd Hoffmann wrote:
>   Hi,
> 
> > > IIRC the drm code checks for the atomic_enable callback presence to
> > > figure whenever it should take the atomic or legacy code paths.
> > 
> > It should check for drm_driver->mode_config.funcs.atomic_commit for that,
> > see drm_drv_uses_atomic_modeset(). Anything else should be a bug.
> > 
> > Or do you mean the fallback to the old crtc helper prepare/commit
> > callbacks?
> 
> Probably the later.  There was some reason why I've left in the empty
> bochs_crtc_atomic_enable() callback ...

Just for checking before I start to work in this patch:
The correct solution should be made atomic_enable and atomic_disable
optional, right? I should do it, and check if Bochs driver really needs
bochs_crtc_atomic_enable after my change, right?

> cheers,
>   Gerd
> 

-- 
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of São Paulo

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)