linux-kernel - Re: [PATCH 00/14] entry: preempt_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5b1605b-b3b3-7898-30ae-d993050e8c7a@arm.com>
Date:   Tue, 12 Mar 2019 18:18:55 +0000
From:   Valentin Schneider <valentin.schneider@....com>
To:     Vineet Gupta <vineet.gupta1@...opsys.com>,
        linux-kernel@...r.kernel.org
Cc:     Julien Thierry <julien.thierry@....com>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-xtensa@...ux-xtensa.org, x86@...nel.org,
        sparclinux@...r.kernel.org, linux-sh@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org,
        linux-mips@...r.kernel.org, uclinux-h8-devel@...ts.sourceforge.jp,
        linux-c6x-dev@...ux-c6x.org, linux-ia64@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
        linux-m68k@...ts.linux-m68k.org, nios2-dev@...ts.rocketboards.org
Subject: Re: [PATCH 00/14] entry: preempt_schedule_irq() callers scrub

On 12/03/2019 18:03, Vineet Gupta wrote:
[...]
>> Regarding that loop, archs seem to fall in 3 categories:
>> A) Those that don't have the loop
> 
> Please clarify that this is the right thing to do (since core code already has the
> loop) hence no fixing is required for this "category"
> 

Right, those don't need any change. I had a brief look at them to double
check they had the proper need_resched() gate before calling
preempt_schedule_irq() (with no loop) and they all seem fine. Also...

>> B) Those that have a small need_resched() loop around the
>>    preempt_schedule_irq() callsite
>> C) Those that branch to some more generic code further up the entry code
>>    and eventually branch back to preempt_schedule_irq()
>>
>> arc, m68k, nios2 fall in A)
> 

I forgot to include parisc in here.

[...]