linux-kernel - Re: [PATCH 02/14] c6x: entry: Remove unneeded need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab0f6cff1dd07ec42f13894d0833fbd506bdc10a.camel@redhat.com>
Date:   Wed, 13 Mar 2019 13:21:58 -0400
From:   Mark Salter <msalter@...hat.com>
To:     Valentin Schneider <valentin.schneider@....com>,
        linux-kernel@...r.kernel.org
Cc:     Aurelien Jacquiot <jacquiot.aurelien@...il.com>,
        linux-c6x-dev@...ux-c6x.org
Subject: Re: [PATCH 02/14] c6x: entry: Remove unneeded need_resched() loop

On Mon, 2019-03-11 at 22:47 +0000, Valentin Schneider wrote:
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
> 
> Signed-off-by: Valentin Schneider <valentin.schneider@....com>
> Cc: Mark Salter <msalter@...hat.com>
> Cc: Aurelien Jacquiot <jacquiot.aurelien@...il.com>
> Cc: linux-c6x-dev@...ux-c6x.org
> ---
>  arch/c6x/kernel/entry.S | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S
> index 2721c90b0121..17926e942edb 100644
> --- a/arch/c6x/kernel/entry.S
> +++ b/arch/c6x/kernel/entry.S
> @@ -567,7 +567,6 @@ resume_kernel:
>  	NOP	4
>   [A1]	BNOP	.S2	restore_all,5
>  
> -preempt_schedule:
>  	GET_THREAD_INFO A2
>  	LDW	.D1T1	*+A2(THREAD_INFO_FLAGS),A1
>  #ifdef CONFIG_C6X_BIG_KERNEL
> @@ -584,7 +583,7 @@ preempt_schedule:
>  #else
>  	B	.S2	preempt_schedule_irq
>  #endif
> -	ADDKPC	.S2	preempt_schedule,B3,4
> +	ADDKPC	.S2	restore_all,B3,4
>  #endif /* CONFIG_PREEMPT */
>  
>  ENTRY(enable_exception)

Acked-by: Mark Salter <msalter@...hat.com>