[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190312035310.GA29476@eros.localdomain>
Date: Tue, 12 Mar 2019 14:53:10 +1100
From: "Tobin C. Harding" <me@...in.cc>
To: Matthew Wilcox <willy@...radead.org>
Cc: Roman Gushchin <guro@...com>,
"Tobin C. Harding" <tobin@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Christoph Lameter <cl@...ux.com>,
Pekka Enberg <penberg@...nel.org>,
David Rientjes <rientjes@...gle.com>,
Joonsoo Kim <iamjoonsoo.kim@....com>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru
On Mon, Mar 11, 2019 at 07:38:28PM -0700, Matthew Wilcox wrote:
> On Tue, Mar 12, 2019 at 12:05:54PM +1100, Tobin C. Harding wrote:
> > > slab_list and lru are in the same bits. Once this patch set is in,
> > > we can remove the enigmatic 'uses lru' comment that I added.
> >
> > Funny you should say this, I came to me today while daydreaming that I
> > should have removed that comment :)
> >
> > I'll remove it in v2.
>
> That's great. BTW, something else you could do to verify this patch
> set is check that the object file is unchanged before/after the patch.
> I tend to use 'objdump -dr' to before.s and after.s and use 'diff'
> to compare the two.
Oh cool, I didn't know to do that. I'm not super familiar with the use
of unions having never had need to use one myself so any other union
related tips you think of please share.
thanks,
Tobin.
Powered by blists - more mailing lists