linux-kernel - Re: [PATCH] kernel/trace/trace_kprobe.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8869c042-aba9-f29b-db16-342d64769e04@infradead.org>
Date:   Tue, 12 Mar 2019 08:14:52 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format

On 3/12/19 8:01 AM, Steven Rostedt wrote:
> On Tue, 12 Mar 2019 04:58:32 -0400
> "Valdis Klētnieks" <valdis.kletnieks@...edu> wrote:
> 
>>   CC      kernel/trace/trace_kprobe.o
>> kernel/trace/trace_kprobe.c:41: warning: cannot understand function prototype: 'struct trace_kprobe '
>>
>> The real problem is that a comment looked like kerneldoc when it shouldn't be...
>>
>> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>
>>
>> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
>> index 9eaf07f99212..c825c591553a 100644
>> --- a/kernel/trace/trace_kprobe.c
>> +++ b/kernel/trace/trace_kprobe.c
>> @@ -35,7 +35,7 @@ static struct dyn_event_operations trace_kprobe_ops = {
>>  	.match = trace_kprobe_match,
>>  };
>>  
>> -/**
>> +/*
> 
> NACK.
> 
> This isn't a kernel doc comment, and I don't want to make it one when
> it is not. Just ignore that warning.
> 
> -- Steve

Huh?  The patch doesn't do that -- it does the opposite of that.
I.e., begin a non-kernel-doc comment with /* instead of /**.

> 
>>   * Kprobe event core functions
>>   */
>>  struct trace_kprobe {
> 


-- 
~Randy