linux-kernel - Re: [PATCH v11] f2fs: guarantee journalled quota data by checkpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Mar 2019 09:17:42 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>
CC:     Chao Yu <chao@...nel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>, Weichao Guo <guoweichao@...wei.com>
Subject: Re: [PATCH v11] f2fs: guarantee journalled quota data by checkpoint

On 2019/3/13 2:28, Jaegeuk Kim wrote:
> On 03/06, Chao Yu wrote:
>> Hi Jaegeuk,
>>
>> On 2018/9/20 20:05, Chao Yu wrote:
>>> @@ -3456,3 +3477,16 @@
>>>
>>>  extern void f2fs_build_fault_attr(struct f2fs_sb_info *sbi, unsigned int rate,
>>>
>>> #endif
>>> #endif
>>> +
>>> +static inline bool is_journalled_quota(struct f2fs_sb_info *sbi)
>>> +{
>>> +#ifdef CONFIG_QUOTA
>>> + if (f2fs_sb_has_quota_ino(sbi->sb))
>>> + return true;
>>> + if (F2FS_OPTION(sbi).s_qf_names[USRQUOTA] ||
>>> + F2FS_OPTION(sbi).s_qf_names[GRPQUOTA] ||
>>> + F2FS_OPTION(sbi).s_qf_names[PRJQUOTA])
>>> + return true;
>>> +#endif
>>> + return false;
>>> +}
>>
>> I checked dev branch, and found one patch we didn't send to mailing list,
>> could you please send it out?
>>
>> f2fs: fix wrong #endif
>>
>> I think my quota patch caused this 'wrong #endif' issue, could you add
>> single line comment to notice which #if the last #endif is corresponding
>> to? so that we can avoid same mistake as quota patch made.
> 
> Ah, I forgot to post the patch. It's quite late but obvious, and thus let me
> keep the patch as is in order to avoid messing up the commit history.

Okay, let me add one other patch for that. :)

Thanks,

> 
> Thanks,
> 
> .
>