linux-kernel - Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cd78fb7-4bcb-b735-54ca-24a179b9ff72@arm.com>
Date:   Wed, 13 Mar 2019 11:22:50 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Sameer Pujar <spujar@...dia.com>, tglx@...utronix.de,
        jason@...edaemon.net, will.deacon@....com, catalin.marinas@....com,
        heiko@...ech.de, horms+renesas@...ge.net.au,
        maxime.ripard@...tlin.com, andy.gross@...aro.org, olof@...om.net,
        bjorn.andersson@...aro.org, jagan@...rulasolutions.com,
        enric.balletbo@...labora.com, stefan.wahren@...e.com,
        ezequiel@...labora.com, marc.w.gonzalez@...e.fr,
        christoffer.dall@....com, drjones@...hat.com,
        julien.thierry@....com
Cc:     treding@...dia.com, jonathanh@...dia.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

First things first:

- Where is the cover letter?
- This series should be flagged as v2, as it not the same as the one you
sent last week.

On 13/03/2019 11:02, Sameer Pujar wrote:
> This is a preparatory patch for using irq-gic-pm driver as module and thus
> implement remove() call for the driver. Details of remove() are as below,
> 
>  * pm_runtime_force_suspend() is added to balance runtime PM, otherwise
>    following is seen: "agic-controller: Unbalanced pm_runtime_enable!"
>  * Function gic_teardown() is exported from gic driver and called in remove
>    to perform io unmap.
>  * pm_clk_destroy() to free clock resources
>  * irq is unmapped and freed with irq_dispose_mapping()
> 

Let's be clear, I have no desire to export any GIC symbol at all. Why
should we do this? This "driver" is the tiniest thing, and making it
modular doesn't get us anything.

So what's the rational for doing so?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...