linux-kernel - Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc00b804-2248-4f8b-1537-3e3db151d74d@nvidia.com>
Date:   Wed, 13 Mar 2019 19:20:24 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Marc Zyngier <marc.zyngier@....com>, <tglx@...utronix.de>,
        <jason@...edaemon.net>, <catalin.marinas@....com>,
        <heiko@...ech.de>, <horms+renesas@...ge.net.au>,
        <maxime.ripard@...tlin.com>, <andy.gross@...aro.org>,
        <olof@...om.net>, <bjorn.andersson@...aro.org>,
        <jagan@...rulasolutions.com>, <enric.balletbo@...labora.com>,
        <stefan.wahren@...e.com>, <ezequiel@...labora.com>,
        <marc.w.gonzalez@...e.fr>, <christoffer.dall@....com>,
        <drjones@...hat.com>, <julien.thierry@....com>
CC:     <will.deacon@....com>, <treding@...dia.com>,
        <jonathanh@...dia.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support


On 3/13/2019 4:52 PM, Marc Zyngier wrote:
> First things first:
>
> - Where is the cover letter?
> - This series should be flagged as v2, as it not the same as the one you
> sent last week.
I had the dilemma whether to name this series as v2 or not, thought the 
commits
in the series are different and v2 may not be necessary.
Also felt commit messages are descriptive enough and all belong to 
irq-gic-pm,
hence did not send cover letter.
If you suggest so, I will send a cover letter next patch version(v2)
>
> On 13/03/2019 11:02, Sameer Pujar wrote:
>> This is a preparatory patch for using irq-gic-pm driver as module and thus
>> implement remove() call for the driver. Details of remove() are as below,
>>
>>   * pm_runtime_force_suspend() is added to balance runtime PM, otherwise
>>     following is seen: "agic-controller: Unbalanced pm_runtime_enable!"
>>   * Function gic_teardown() is exported from gic driver and called in remove
>>     to perform io unmap.
>>   * pm_clk_destroy() to free clock resources
>>   * irq is unmapped and freed with irq_dispose_mapping()
>>
> Let's be clear, I have no desire to export any GIC symbol at all. Why
> should we do this? This "driver" is the tiniest thing, and making it
> modular doesn't get us anything.
>
> So what's the rational for doing so?
Reason for this was, the driver gets used for AGIC block and audio is not
boot critical and hence module option was preferred.

Thanks,
Sameer.

>
> Thanks,
>
> 	M.