linux-kernel - Re: [PATCH v7 08/12] perf record: implement compression for AIO trace streaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16580fcc-23ae-dfa1-60ae-963fb4ae3207@linux.intel.com>
Date:   Wed, 13 Mar 2019 18:33:35 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 08/12] perf record: implement compression for AIO trace
 streaming


On 13.03.2019 17:36, Jiri Olsa wrote:
> On Tue, Mar 12, 2019 at 08:30:13AM +0300, Alexey Budankov wrote:
> 
> SNIP
> 
>> -
>> -	md->prev = head;
>> -	perf_mmap__consume(md);
>> -
>> -	rc = push(to, &md->aio.cblocks[idx], md->aio.data[idx], size0 + size, *off);
>> -	if (!rc) {
>> -		*off += size0 + size;
>> -	} else {
>> -		/*
>> -		 * Decrement md->refcount back if aio write
>> -		 * operation failed to start.
>> -		 */
>> -		perf_mmap__put(md);
>> -	}
>> -
>> -	return rc;
>> -}
>>  #else /* !HAVE_AIO_SUPPORT */
>>  static int perf_mmap__aio_enabled(struct perf_mmap *map __maybe_unused)
>>  {
>> @@ -566,7 +492,7 @@ int perf_mmap__push(struct perf_mmap *md, void *to,
>>  
>>  	rc = perf_mmap__read_init(md);
>>  	if (rc < 0)
>> -		return (rc == -EAGAIN) ? 0 : -1;
>> +		return (rc == -EAGAIN) ? 1 : -1;
> 
> hum, should this be in part of this one?
> 
>   perf record: implement -f,--mmap-flush=<threshold> option

It affects the both serial and AIO but currently is only used 
in AIO flow. That is why it is placed here.

~Alexey

> 
> 
> jirka
>