linux-kernel - Re: [PATCH] signal: annotate implicit fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+7wUswdVU=JuHPAVo9gxZJ8BYWhThnsLggVM5t9h--=AhCPPQ@mail.gmail.com>
Date:   Wed, 13 Mar 2019 21:27:14 +0100
From:   Mathieu Malaterre <malat@...ian.org>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH] signal: annotate implicit fall through

ping ?

On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre <malat@...ian.org> wrote:
>
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
>   kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>  kernel/signal.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index e1d7ad8e6ab1..aa7a507757d7 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
>                          */
>                         if (!sid || sid == task_session(current))
>                                 break;
> +                       /* fall through */
>                 default:
>                         return -EPERM;
>                 }
> --
> 2.19.2
>