linux-kernel - Re: [PATCH] signal: annotate implicit fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba0a1ec8-b3d7-7214-ffcb-031304d463ee@embeddedor.com>
Date:   Mon, 1 Apr 2019 14:51:47 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Mathieu Malaterre <malat@...ian.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] signal: annotate implicit fall through

[+cc Andrew]

On 3/13/19 3:27 PM, Mathieu Malaterre wrote:
> ping ?
> 

Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Maybe Andrew can take this?

Thanks
--
Gustavo

> On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre <malat@...ian.org> wrote:
>>
>> There is a plan to build the kernel with -Wimplicit-fallthrough and
>> this place in the code produced a warning (W=1).
>>
>> This commit remove the following warning:
>>
>>   kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
>> ---
>>  kernel/signal.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/signal.c b/kernel/signal.c
>> index e1d7ad8e6ab1..aa7a507757d7 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
>>                          */
>>                         if (!sid || sid == task_session(current))
>>                                 break;
>> +                       /* fall through */
>>                 default:
>>                         return -EPERM;
>>                 }
>> --
>> 2.19.2
>>