linux-kernel - Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9psZb0XoKHjGP23TYsSwMU2G-WN81RKg8AvyY-rZLvy4g@mail.gmail.com>
Date:   Wed, 13 Mar 2019 14:34:23 -0600
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

Conceptually this seems pretty reasonable. Though, style-wise, perhaps
you might want to put those breaks on the next line too, i.e. s/;
break;/;\n\t\tbreak;/?