linux-kernel - Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93bba19a-472a-c7fe-cee7-55ff3f4c48ec@embeddedor.com>
Date:   Wed, 13 Mar 2019 15:44:25 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        Mathieu Malaterre <malat@...ian.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs



On 3/13/19 3:34 PM, Jason A. Donenfeld wrote:
> Conceptually this seems pretty reasonable. Though, style-wise, perhaps
> you might want to put those breaks on the next line too, i.e. s/;
> break;/;\n\t\tbreak;/?
> 

I agree.

With that, you can add my:

Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Thanks
--
Gustavo