linux-kernel - Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+7wUsxbieZVP3Bh8pXdemf2Q3qY3vAjE2y-Dg6yGF3oWHSPuQ@mail.gmail.com>
Date:   Wed, 13 Mar 2019 21:52:41 +0100
From:   Mathieu Malaterre <malat@...ian.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

On Wed, Mar 13, 2019 at 9:34 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
>
> Conceptually this seems pretty reasonable. Though, style-wise, perhaps
> you might want to put those breaks on the next line too, i.e. s/;
> break;/;\n\t\tbreak;/?

Good point. This needs some more love since checkpatch complains now with:

ERROR: trailing statements should be on next line
#42: FILE: lib/siphash.c:77:
+ case 4: b |= le32_to_cpup(data);

Let me merge all that and send a v2.

Thanks