linux-kernel - Re: [PATCH 1/2] cifs: remove unused status severity defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Mar 2019 16:12:45 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Steve French <smfrench@...il.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH 1/2] cifs: remove unused status severity defines

On (03/14/19 02:04), Steve French wrote:
[..]
>  #define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x0000)

Does STATUS_SEVERITY_SUCCESS still use __constant_cpu_to_le32?

> -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001)
> -#define STATUS_SEVERITY_WARNING __constanst_cpu_to_le32(0x0002)
> -#define STATUS_SEVERITY_ERROR __constanst_cpu_to_le32(0x0003)
> +#define STATUS_SEVERITY_INFORMATIONAL cpu_to_le32(0x0001)
> +#define STATUS_SEVERITY_WARNING cpu_to_le32(0x0002)
> +#define STATUS_SEVERITY_ERROR cpu_to_le32(0x0003)

Otherwise looks good.

	-ss