linux-kernel - Re: [PATCH 1/2] cifs: remove unused status severity defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5ms3sdFx864M4se0V1eCAj_x8_3xyyRxoxqS52_UQNNjaA@mail.gmail.com>
Date:   Thu, 14 Mar 2019 02:19:53 -0500
From:   Steve French <smfrench@...il.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH 1/2] cifs: remove unused status severity defines

All of those uses of __constant_cpu_to_le32 apparently (at least
according to checkpatch) should be changed (someday) to cpu_to_le32
but I didn't research why the change from __constant_cpu_to_le32
--->   cpu_to_le32

If it has benefit - and checkpatch is right (it warned about
__constant_cpu_to_le32 being no longer preferred) ... perhaps would be
worth a followup patch to clean the rest of them up?   If you have any
context on why kernel code has moved away from using the older format
of __constant_cpu_to_.... would be useful to know if any benefit to
the change

On Thu, Mar 14, 2019 at 2:12 AM Sergey Senozhatsky
<sergey.senozhatsky.work@...il.com> wrote:
>
> On (03/14/19 02:04), Steve French wrote:
> [..]
> >  #define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x0000)
>
> Does STATUS_SEVERITY_SUCCESS still use __constant_cpu_to_le32?
>
> > -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001)
> > -#define STATUS_SEVERITY_WARNING __constanst_cpu_to_le32(0x0002)
> > -#define STATUS_SEVERITY_ERROR __constanst_cpu_to_le32(0x0003)
> > +#define STATUS_SEVERITY_INFORMATIONAL cpu_to_le32(0x0001)
> > +#define STATUS_SEVERITY_WARNING cpu_to_le32(0x0002)
> > +#define STATUS_SEVERITY_ERROR cpu_to_le32(0x0003)
>
> Otherwise looks good.
>
>         -ss



-- 
Thanks,

Steve