linux-kernel - Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Mar 2019 10:39:12 +0100
From:   Pavel Machek <pavel@....cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     robh+dt@...nel.org, jacek.anaszewski@...il.com, tony@...mide.com,
        lee.jones@...aro.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu
 doc

Hi!

Could you maybe slow down a bit.

"Hey, I should review this". "Hmm, there are two new versions in the
mailbox in the meantime, good thing I waited."

> +	ramp-up-ms = <1024>;
> +	ramp-down-ms = <65536>;

This is wrong.

> +	led@1 {
> +		reg = <1>;
> +		led-sources = <1>;
> +		ti,led-mode = <0>;
> +		label = "keypad";

"platform::kbd_backlight"
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)