linux-kernel - Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75def574-5fe4-46c0-664f-8c6583b69668@ti.com>
Date:   Thu, 14 Mar 2019 07:52:04 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <robh+dt@...nel.org>, <jacek.anaszewski@...il.com>,
        <tony@...mide.com>, <lee.jones@...aro.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-leds@...r.kernel.org>
Subject: Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu
 doc

Hello

On 3/14/19 4:39 AM, Pavel Machek wrote:
> Hi!
> 
> Could you maybe slow down a bit.
> 
> "Hey, I should review this". "Hmm, there are two new versions in the
> mailbox in the meantime, good thing I waited."
> 

Yes.  I am going to hold off on v5 until the code gets reviewed.

>> +	ramp-up-ms = <1024>;
>> +	ramp-down-ms = <65536>;
> 
> This is wrong.
> 

Ack.  Changed in it in the example I deleted.

>> +	led@1 {
>> +		reg = <1>;
>> +		led-sources = <1>;
>> +		ti,led-mode = <0>;
>> +		label = "keypad";
> 
> "platform::kbd_backlight"

Being an example does it have to match DT contents?

I can change it since I have to touch the file anyway.

Dan


> 									Pavel
> 


-- 
------------------
Dan Murphy