linux-kernel - Re: [PATCH v1] xen/balloon: Fix mapping PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2268eedd-65f6-4715-792f-702bfca4659c@redhat.com>
Date:   Thu, 14 Mar 2019 16:59:50 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Oscar Salvador <osalvador@...e.de>
Cc:     xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Julien Grall <julien.grall@....com>,
        Matthew Wilcox <willy@...radead.org>,
        Nadav Amit <namit@...are.com>,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        akpm@...ux-foundation.org, linux-mm@...ck.org
Subject: Re: [PATCH v1] xen/balloon: Fix mapping PG_offline pages to user
 space

On 14.03.19 16:49, Oscar Salvador wrote:
> On Thu, Mar 14, 2019 at 04:40:25PM +0100, David Hildenbrand wrote:
>> @@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
>>  
>>  	for (i = 0; i < nr_pages; i++) {
>>  		if (pages[i])
>> +			__SetPageOffline(pages[i]);
>>  			balloon_append(pages[i]);
> 
> didn't you forget {} there? ;-)
> 

That's what happens when you stashed the original patch and try to
recreate it quickly from a mail ;)

Thanks!


-- 

Thanks,

David / dhildenb