linux-kernel - Re: [Xen-devel] [PATCH v1] xen/balloon: Fix mapping PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81175478-d6cf-56ce-587c-87473e79fd50@redhat.com>
Date:   Thu, 14 Mar 2019 17:00:15 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Jan Beulich <JBeulich@...e.com>
Cc:     Julien Grall <julien.grall@....com>,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        Matthew Wilcox <willy@...radead.org>,
        Stefano Stabellini <sstabellini@...nel.org>,
        linux-mm@...ck.org, akpm@...ux-foundation.org,
        xen-devel <xen-devel@...ts.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
        Nadav Amit <namit@...are.com>
Subject: Re: [Xen-devel] [PATCH v1] xen/balloon: Fix mapping PG_offline pages
 to user space

On 14.03.19 16:49, Jan Beulich wrote:
>>>> On 14.03.19 at 16:40, <david@...hat.com> wrote:
>> --- a/drivers/xen/balloon.c
>> +++ b/drivers/xen/balloon.c
>> @@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
>>  	while (pgno < nr_pages) {
>>  		page = balloon_retrieve(true);
>>  		if (page) {
>> +			__ClearPageOffline(page);
>>  			pages[pgno++] = page;
> 
> While this one's fine, ...
> 
>> @@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
>>  
>>  	for (i = 0; i < nr_pages; i++) {
>>  		if (pages[i])
>> +			__SetPageOffline(pages[i]);
>>  			balloon_append(pages[i]);
>>  	}
> 
> ... I think you want to add a pair of braces here.
> 
> Jan
> 
> 

Indeed, dropped by accident. Will resend in a minute. Thanks!

-- 

Thanks,

David / dhildenb