linux-kernel - RE: [PATCH 2/2] cifs: don't use __constant_cpu_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <757dbafbdadb45f6a3de728ecfd05c5d@AcuMS.aculab.com>
Date:   Fri, 15 Mar 2019 12:31:22 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Sergey Senozhatsky' <sergey.senozhatsky.work@...il.com>,
        Steve French <sfrench@...ba.org>
CC:     "linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
        "samba-technical@...ts.samba.org" <samba-technical@...ts.samba.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Sergey Senozhatsky" <sergey.senozhatsky@...il.com>
Subject: RE: [PATCH 2/2] cifs: don't use __constant_cpu_to_le32()

From: Sergey Senozhatsky
> 
> cpu_to_le32() is capable enough to detect __builtin_constant_p()
> and to use an appropriate compile time ___constant_swahb32()
> function.
> 
> So we can use cpu_to_le32() instead of __constant_cpu_to_le32().

Unless any code tries to use them as case statement labels.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)