linux-kernel - Re: [RFC PATCH v2 4/7] i2c: demux: WIP: handle the new atomic callbacks

Open Source and information security mailing list archives

Message-ID: <20190315123249.mlymbgwi3rxtt4d3@verge.net.au>
Date:   Fri, 15 Mar 2019 13:32:49 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-i2c@...r.kernel.org, Tero Kristo <t-kristo@...com>,
        Phil Reid <preid@...ctromag.com.au>,
        Tony Lindgren <tony@...mide.com>, Keerthy <j-keerthy@...com>,
        linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
        linux-renesas-soc@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-tegra@...r.kernel.org,
        Stefan Lengfeld <contact@...fanchrist.eu>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Peter Rosin <peda@...ntia.se>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH v2 4/7] i2c: demux: WIP: handle the new atomic
 callbacks

On Sat, Mar 02, 2019 at 02:47:32PM +0100, Wolfram Sang wrote:
> If the parent has an atomic callback, we need to translate it the same
> way as the non-atomic callback.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  drivers/i2c/muxes/i2c-demux-pinctrl.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
> index 035032e20327..5d00adfbe578 100644
> --- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
> +++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
> @@ -99,6 +99,9 @@ static int i2c_demux_activate_master(struct i2c_demux_pinctrl_priv *priv, u32 ne
>  
>  	/* Now fill out current adapter structure. cur_chan must be up to date */
>  	priv->algo.master_xfer = i2c_demux_master_xfer;
> +	/* FIXME: regular muxes need proper handling, too! */
> +	if (adap->algo->master_xfer_atomic)
> +		priv->algo.master_xfer_atomic = i2c_demux_master_xfer;
>  	priv->algo.functionality = i2c_demux_functionality;
>  
>  	snprintf(priv->cur_adap.name, sizeof(priv->cur_adap.name),
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives