linux-kernel - Re: [PATCH] firmware: vpd: Drop __iomem usage for memremap() memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190318183636.GA31345@roeck-us.net>
Date:   Mon, 18 Mar 2019 11:36:36 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Anton Vasilyev <vasilyev@...ras.ru>
Subject: Re: [PATCH] firmware: vpd: Drop __iomem usage for memremap() memory

On Mon, Mar 18, 2019 at 08:54:57AM -0700, Stephen Boyd wrote:
> memremap() doesn't return an iomem pointer, so we can just use memcpy()
> and drop the __iomem annotation here. This silences a sparse warning.
> 
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Anton Vasilyev <vasilyev@...ras.ru>
> Smgned-off-by: Stephen Boyd <swboyd@...omium.org>

Smgned ?

Other than that,

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/firmware/google/vpd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
> index c0c0b4e4e281..f240946ed701 100644
> --- a/drivers/firmware/google/vpd.c
> +++ b/drivers/firmware/google/vpd.c
> @@ -254,7 +254,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
>  
>  static int vpd_sections_init(phys_addr_t physaddr)
>  {
> -	struct vpd_cbmem __iomem *temp;
> +	struct vpd_cbmem *temp;
>  	struct vpd_cbmem header;
>  	int ret = 0;
>  
> @@ -262,7 +262,7 @@ static int vpd_sections_init(phys_addr_t physaddr)
>  	if (!temp)
>  		return -ENOMEM;
>  
> -	memcpy_fromio(&header, temp, sizeof(struct vpd_cbmem));
> +	memcpy(&header, temp, sizeof(struct vpd_cbmem));
>  	memunmap(temp);
>  
>  	if (header.magic != VPD_CBMEM_MAGIC)
> -- 
> Sent by a computer through tubes
>