linux-kernel - Re: [PATCH] firmware: vpd: Drop __iomem usage for memremap() memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Mar 2019 12:38:49 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Anton Vasilyev <vasilyev@...ras.ru>
Subject: Re: [PATCH] firmware: vpd: Drop __iomem usage for memremap() memory

Quoting Guenter Roeck (2019-03-18 11:36:36)
> On Mon, Mar 18, 2019 at 08:54:57AM -0700, Stephen Boyd wrote:
> > memremap() doesn't return an iomem pointer, so we can just use memcpy()
> > and drop the __iomem annotation here. This silences a sparse warning.
> > 
> > Cc: Guenter Roeck <linux@...ck-us.net>
> > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Cc: Anton Vasilyev <vasilyev@...ras.ru>
> > Smgned-off-by: Stephen Boyd <swboyd@...omium.org>
> 
> Smgned ?

Hm, something went wrong!

> 
> Other than that,
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Thanks. I'll resend with everything fixed.