linux-kernel - Re: [PATCH v2] iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190318101703.GA6100@8bytes.org>
Date:   Mon, 18 Mar 2019 11:17:03 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Stanislaw Gruszka <sgruszka@...hat.com>
Cc:     Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Rosen Penev <rosenp@...il.com>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Samuel Sieb <samuel@...b.net>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org, jan.viktorin@...il.com
Subject: Re: [PATCH v2] iommu/amd: fix sg->dma_address for sg->offset bigger
 than PAGE_SIZE

Hi Stanislaw,

thanks a lot for looking into this and tracking it down!

On Wed, Mar 13, 2019 at 10:03:17AM +0100, Stanislaw Gruszka wrote:
> -		s->dma_address += address + s->offset;
> +		/* Add in the remaining piece of the scatter-gather offset that
> +		 * was masked out when we were determining the physical address
> +		 * via (sg_phys(s) & PAGE_MASK) earlier.
> +		 */
> +		s->dma_address += address + (s->offset & ~PAGE_MASK);
>  		s->dma_length   = s->length;

Applied the patch for v5.1 (with an added Fixes-tag and a minor coding
style change) and will send it upstream soon.

Thanks again,

       Joerg