linux-kernel - Static analysis bug report: atm: idt77252

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 18 Mar 2019 10:17:49 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Chas Williams <3chas3@...il.com>,
        linux-atm-general@...ts.sourceforge.net,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Static analysis bug report: atm: idt77252

Hi,

Static analysis with cppcheck has detected an uninitialized variable in
the idt77252 driver:

The variable linkrate is only initialized when
CONFIG_ATM_IDT77252_USE_SUNI is enabled:

#ifdef  CONFIG_ATM_IDT77252_USE_SUNI
        /*
         * this is a jhs hack to get around special functionality in the
         * phy driver for the atecom hardware; the functionality doesn't
         * exist in the linux atm suni driver
         *
         * it isn't the right way to do things, but as the guy from NIST
         * said, talking about their measurement of the fine structure
         * constant, "it's good enough for government work."
         */
        linkrate = 149760000;
#endif

        card->link_pcr = (linkrate / 8 / 53);

I suspect the driver is being used with CONFIG_ATM_IDT77252_USE_SUNI
enabled, however, this probably needs fixing with the correct value
(whatever that is) when CONFIG_ATM_IDT77252_USE_SUNI is not enabled.

Colin