linux-kernel - Re: [PATCH] printk: Remove no longer used console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Mar 2019 23:34:21 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] printk: Remove no longer used console_silent().

On (03/18/19 23:05), Tetsuo Handa wrote:
> console_silent() is no longer used after the removal of
> arch/mn10300/kernel/mn10300-watchdog.c in Linux 4.17-rc1.

[..]

> -static inline void console_silent(void)
> -{
> -	console_loglevel = CONSOLE_LOGLEVEL_SILENT;
> -}

I would keep it, I guess, and would instead covert

kernel/debug/kdb/kdb_io.c:              console_loglevel = CONSOLE_LOGLEVEL_SILENT

to use proper API (console_silent()).

	-ss