linux-kernel - Re: [PATCH] printk: Remove no longer used console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190320143919.6n7az5yi5hbhipk4@pathway.suse.cz>
Date:   Wed, 20 Mar 2019 15:39:19 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] printk: Remove no longer used console_silent().

On Mon 2019-03-18 23:34:21, Sergey Senozhatsky wrote:
> On (03/18/19 23:05), Tetsuo Handa wrote:
> > console_silent() is no longer used after the removal of
> > arch/mn10300/kernel/mn10300-watchdog.c in Linux 4.17-rc1.
> 
> [..]
> 
> > -static inline void console_silent(void)
> > -{
> > -	console_loglevel = CONSOLE_LOGLEVEL_SILENT;
> > -}
> 
> I would keep it, I guess, and would instead covert
> 
> kernel/debug/kdb/kdb_io.c:              console_loglevel = CONSOLE_LOGLEVEL_SILENT
> 
> to use proper API (console_silent()).

I agree with Sergey.

Best Regards,
Petr