linux-kernel - Re: [PATCH 05/10] staging: rtl8723bs: Remove unreachable Code in core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190319093237.GO2227@kadam>
Date:   Tue, 19 Mar 2019 12:32:37 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Emanuel Bennici <benniciemanuel78@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Arnd Bergmann <arnd@...db.de>,
        Hardik Singh Rathore <hardiksingh.k@...il.com>,
        Nathan Chancellor <natechancellor@...il.com>
Subject: Re: [PATCH 05/10] staging: rtl8723bs: Remove unreachable Code in
 core/rtw_cmd.c

On Sun, Mar 17, 2019 at 07:31:08PM +0100, Emanuel Bennici wrote:
> The `case INTEl_WIDI_WK_CID`-Statement in Function `u8 rtw_drvextra_cmd_hdl`
> wouldn't be used because of CONFIG_INTEL_WIDI.
> 
> Signed-off-by: Emanuel Bennici <benniciemanuel78@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 91520ca3bbad..6c6ddf461590 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -2007,11 +2007,6 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
>  	case CHECK_HIQ_WK_CID:
>  		rtw_chk_hi_queue_hdl(padapter);
>  		break;
> -#ifdef CONFIG_INTEL_WIDI
> -	case INTEl_WIDI_WK_CID:
> -		intel_widi_wk_hdl(padapter, pdrvextra_cmd->type, pdrvextra_cmd->pbuf);
> -		break;
> -#endif /* CONFIG_INTEL_WIDI */

Could you just remove all the CONFIG_INTEL_WIDI at once?  That would be
easier to review.

(I don't know where the other patches from this series are.  Maybe gmail
ate them).

regards,
dan carpenter