linux-kernel - Re: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Mar 2019 11:25:03 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Anson Huang <anson.huang@....com>
Cc:     "mark.rutland@....com" <mark.rutland@....com>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        Robin Gong <yibin.gong@....com>,
        "schnitzeltony@...il.com" <schnitzeltony@...il.com>,
        "otavio@...ystems.com.br" <otavio@...ystems.com.br>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "jan.tuerk@...rion.com" <jan.tuerk@...rion.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Leonard Crestez <leonard.crestez@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight support

On Tue, Mar 19, 2019 at 09:11:38AM +0000, Anson Huang wrote:
> Hi,
> 
> Best Regards!
> Anson Huang
> 
> > -----Original Message-----
> > From: Uwe Kleine-König [mailto:u.kleine-koenig@...gutronix.de]
> > Sent: 2019年3月19日 16:15
> > To: Anson Huang <anson.huang@....com>
> > Cc: thierry.reding@...il.com; robh+dt@...nel.org; mark.rutland@....com;
> > shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> > festevam@...il.com; linux@...linux.org.uk; stefan@...er.ch;
> > otavio@...ystems.com.br; Leonard Crestez <leonard.crestez@....com>;
> > schnitzeltony@...il.com; jan.tuerk@...rion.com; Robin Gong
> > <yibin.gong@....com>; linux-pwm@...r.kernel.org;
> > devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> > kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> > Subject: Re: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight
> > support
> > 
> > On Tue, Mar 19, 2019 at 07:09:56AM +0000, Anson Huang wrote:
> > > i.MX7ULP EVK board has MIPI-DSI display, its backlight is supplied by
> > > TPM PWM module, this patch set enables i.MX7ULP TPM PWM driver
> > support
> > > and also add backlight support for MIPI-DSI display.
> > 
> > Given that you actually changed something compared to v6, this is not a
> > resend but v7. Also I suggest to practise a bit of patience before sending out
> > a new revision to prevent people still looking at the previous round. I just
> > gave feedback to the original v6 which you obviously didn't address :-|
> > 
> > Also a highlevel changelog for the series (here something like: "Properly
> > separate dt changes into soc-specific and machine-specific changes") is
> > helpful.
> 
> OK, will pay attention to that, the resend is just because the patch content is NOT
> Changed, just re-organize the DT patch.
> 
> Also, I understand that sending the patch version too quickly will result in too many
> Patch version in this thread, but I just want to address the comments ASAP when I
> Have time, hope that does NOT bother reviewer too much...

A middle way is to provide a git-tree somewhere and in reply to a review
just say: I updated the patches according to your feedback, but will
wait a bit more for further feedback before resending. If you're
interested the current work in progress can be found at git://... in the
xyz branch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |