linux-kernel - Re: [PATCH] tools: PCI: exit with error code when test fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Mar 2019 15:43:22 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Jean-Jacques Hiblot <jjhiblot@...com>, kishon@...com
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools: PCI: exit with error code when test fails

On Fri, Nov 16, 2018 at 12:01:13PM +0000, Lorenzo Pieralisi wrote:
> On Thu, Oct 04, 2018 at 12:11:44PM +0100, Lorenzo Pieralisi wrote:
> > On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote:
> > > This makes it easier to use pcitest in automated setups.
> > > 
> > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@...com>
> > > ---
> > >  tools/pci/pcitest.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> > > index af146bb..5adc8cd 100644
> > > --- a/tools/pci/pcitest.c
> > > +++ b/tools/pci/pcitest.c
> > > @@ -143,6 +143,7 @@ static int run_test(struct pci_test *test)
> > >  	}
> > >  
> > >  	fflush(stdout);
> > > +	return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
> > >  }
> > >  
> > >  int main(int argc, char **argv)
> > > @@ -231,6 +232,5 @@ int main(int argc, char **argv)
> > >  		return -EINVAL;
> > >  	}
> > >  
> > > -	run_test(test);
> > > -	return 0;
> > > +	return run_test(test);
> > >  }
> > > -- 
> > > 2.7.4
> > > 
> > 
> > Hi Kishon,
> > 
> > are you OK with this patch ? Please let me know.
> 
> Please let me know, I need your ACK on this to queue it.

Hi Kishon,

I will merge this patch unless you have something against it,
please let me know.

Thanks,
Lorenzo