linux-kernel - Re: [PATCH] tools: PCI: exit with error code when test fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <285c3f6f-edfb-db9f-4816-82a8c4b5c97d@ti.com>
Date:   Wed, 20 Mar 2019 10:42:31 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jean-Jacques Hiblot <jjhiblot@...com>
CC:     <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools: PCI: exit with error code when test fails



On 19/03/19 9:13 PM, Lorenzo Pieralisi wrote:
> On Fri, Nov 16, 2018 at 12:01:13PM +0000, Lorenzo Pieralisi wrote:
>> On Thu, Oct 04, 2018 at 12:11:44PM +0100, Lorenzo Pieralisi wrote:
>>> On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote:
>>>> This makes it easier to use pcitest in automated setups.
>>>>
>>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@...com>
>>>> ---
>>>>  tools/pci/pcitest.c | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
>>>> index af146bb..5adc8cd 100644
>>>> --- a/tools/pci/pcitest.c
>>>> +++ b/tools/pci/pcitest.c
>>>> @@ -143,6 +143,7 @@ static int run_test(struct pci_test *test)
>>>>  	}
>>>>  
>>>>  	fflush(stdout);
>>>> +	return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
>>>>  }
>>>>  
>>>>  int main(int argc, char **argv)
>>>> @@ -231,6 +232,5 @@ int main(int argc, char **argv)
>>>>  		return -EINVAL;
>>>>  	}
>>>>  
>>>> -	run_test(test);
>>>> -	return 0;
>>>> +	return run_test(test);
>>>>  }
>>>> -- 
>>>> 2.7.4
>>>>
>>>
>>> Hi Kishon,
>>>
>>> are you OK with this patch ? Please let me know.
>>
>> Please let me know, I need your ACK on this to queue it.
> 
> Hi Kishon,
> 
> I will merge this patch unless you have something against it,
> please let me know.

Sorry for missing this earlier.

Acked-by: Kishon Vijay Abraham I <kishon@...com>
> 
> Thanks,
> Lorenzo
>