linux-kernel - Re: [PATCH v2 01/19] locking/lockdep: Change all print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1553013040.152266.49.camel@acm.org>
Date:   Tue, 19 Mar 2019 09:30:40 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Joe Perches <joe@...ches.com>, Yuyang Du <duyuyang@...il.com>,
        peterz@...radead.org, will.deacon@....com, mingo@...nel.org
Cc:     ming.lei@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/19] locking/lockdep: Change all print_*() return
 type to void

On Mon, 2019-03-18 at 02:45 -0700, Joe Perches wrote:
> > -static void
> > -print_circular_lock_scenario(struct held_lock *src,
> > -			     struct held_lock *tgt,
> > -			     struct lock_list *prt)
> > +static void print_circular_lock_scenario(struct held_lock *src,
> > +					 struct held_lock *tgt,
> > +					 struct lock_list *prt)
> 
> trivia:
> 
> This style change seems superfluous as many
> other existing functions use the previous style.

I share Joe's opinion. 

Bart.