linux-kernel - Re: [PATCH] NFC: pn533: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c9a29a0-18e5-f7e2-1f60-8a87f4625d63@embeddedor.com>
Date:   Wed, 20 Mar 2019 14:21:09 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Samuel Ortiz <sameo@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NFC: pn533: mark expected switch fall-throughs

Hi all,

If no one cares, I'll add this to my tree for 5.2

Thanks
--
Gustavo

On 2/13/19 12:57 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warnings:
> 
> drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:
> drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
>       ^
> drivers/nfc/pn533/pn533.c:2150:2: note: here
>   default:
>   ^~~~~~~
> drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:
> drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
>       ^
> drivers/nfc/pn533/pn533.c:2276:2: note: here
>   default:
>   ^~~~~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Addresses-Coverity-ID: 1230487 ("Missing break in switch")
> Addresses-Coverity-ID: 1230488 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/nfc/pn533/pn533.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c
> index a0cc1cc45292..5961f14259e5 100644
> --- a/drivers/nfc/pn533/pn533.c
> +++ b/drivers/nfc/pn533/pn533.c
> @@ -2147,6 +2147,7 @@ static int pn533_transceive(struct nfc_dev *nfc_dev,
>  
>  			break;
>  		}
> +		/* fall through */
>  	default:
>  		/* jumbo frame ? */
>  		if (skb->len > PN533_CMD_DATAEXCH_DATA_MAXLEN) {
> @@ -2273,6 +2274,7 @@ static void pn533_wq_mi_recv(struct work_struct *work)
>  
>  			break;
>  		}
> +		/* fall through */
>  	default:
>  		skb_put_u8(skb, 1); /*TG*/
>  
>